feat(search): Only reindex if the mappings for an existing field changed #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…ged (datahub-project#4629) * Just update mappings as much as possible * Fix checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, everytime mappings or settings for a given entity updates, we reindex the whole search index. This has led to us reindexing huge indices every time a new searchable field has been added to the model. This is very unnecessary.
There have been two sources of diffs
a) a new searchable field causes mappings diff
b) a new entity causes changes in urn stop filters (which adds the list of entities to the list of stop words to remove when indexing urns)
This PR aims to make sure we do not reindex on the above two cases. Reindex will only happen when a mappings for an existing field needs to change.
Checklist