Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(KafkaEmitter): Enable ability to run test locally #6123

Conversation

david-leifker
Copy link
Collaborator

Adjusting KafkaEmitterTest to run locally. Hopefully preserving its ability to run via GHA. Branched from the M1 branch so I could run it locally first.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker david-leifker changed the title David leifker/kafka emitter test test(KafkaEmitter): Enable ability to run test locally Oct 5, 2022
@david-leifker david-leifker force-pushed the david-leifker/kafka-emitter-test branch from 79c44fd to facfff7 Compare October 5, 2022 18:21
david-leifker and others added 14 commits October 6, 2022 09:06
* starting improvements on search snippet

* flesh out ranking logic

* adding tests

* responding to comments
…roject#6013)

* refactor(ingest): use pydantic utilities for NamingPattern

* clean up replacement logic

* flatten config hierarchy
…atahub-project#6120)

* Added information about AUTH_OIDC_EXTRACT_GROUPS_ENABLED

* Update configure-oidc-react-okta.md

Co-authored-by: Aditya Radhakrishnan <aditya.radhakrish@gmail.com>
@david-leifker david-leifker force-pushed the david-leifker/kafka-emitter-test branch from facfff7 to 7fd3814 Compare October 6, 2022 14:06
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results (build & test)

591 tests  ±0   587 ✔️ ±0   12m 5s ⏱️ -42s
146 suites ±0       4 💤 ±0 
146 files   ±0       0 ±0 

Results for commit 26a5be8. ± Comparison against base commit 928f294.

@shirshanka shirshanka merged commit 3dc25c1 into datahub-project:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants