feat(lineage): show fully qualified task name in lineage UI #6126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Oct 5, 2022
| @@ -22,6 +22,24 @@ const getDataJobPlatformName = (data?: DataJob): string => { | |||
| return data?.dataFlow?.platform?.properties?.displayName || data?.dataFlow?.platform?.name || ''; | |||
| }; | |||
|
|
|||
| const getExpandedNameForDataJob = (entity: DataJob): string => { | |||
| const name = entity?.properties?.name; | |||
There was a problem hiding this comment.
what do you think about doing const name = new DataJobEntity().displayName(entity); in order to keep getting display names for dataJobs consistent?
| @@ -178,6 +196,7 @@ export class DataJobEntity implements Entity<DataJob> { | |||
| return { | |||
| urn: entity?.urn, | |||
| name: entity?.properties?.name || '', | |||
There was a problem hiding this comment.
and if we're gonna be consistent about using displayName we could also update this here to be name: this.displayName(entity),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows option to see full name of a task (data flow . task) in lineage viz.
Checklist