Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): add trino package max version restriction #6137

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 6, 2022

See trinodb/trino-python-client#250.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 52s ⏱️ +34s
   732 tests ±0     729 ✔️ +3  3 💤 ±0  0  - 3 
1 466 runs  ±0  1 460 ✔️ +5  6 💤 ±0  0  - 5 

Results for commit f5916f2. ± Comparison against base commit 3106e42.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results (build & test)

591 tests  ±0   587 ✔️ ±0   12m 50s ⏱️ -11s
146 suites ±0       4 💤 ±0 
146 files   ±0       0 ±0 

Results for commit f5916f2. ± Comparison against base commit 3106e42.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 3f84a20 into datahub-project:master Oct 6, 2022
@hsheth2 hsheth2 deleted the trino-version branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants