Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(neo4j): Improve test performance #6142

Merged
merged 3 commits into from
Oct 24, 2022
Merged

test(neo4j): Improve test performance #6142

merged 3 commits into from
Oct 24, 2022

Conversation

david-leifker
Copy link
Collaborator

Reuse neo4j graph service in test for performance improvements.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker
test(neo4j): Improve test performance
c02ee4a 
Reuse neo4j graph service in test for performance improvements.
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 43s ⏱️ +2s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 73ecc58. ± Comparison against base commit ac67799.

♻️ This comment has been updated with latest results.

gabe-lyons
gabe-lyons approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thanks @david-leifker !

@gabe-lyons gabe-lyons merged commit 7cdc9f7 into datahub-project:master Oct 24, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@david-leifker @cccs-tom
test(neo4j): Improve test performance (datahub-project#6142)
400fcd3 
Reuse neo4j graph service in test for performance improvements.
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@david-leifker @cccs-tom
test(neo4j): Improve test performance (datahub-project#6142)
b0211e9 
Reuse neo4j graph service in test for performance improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @gabe-lyons