Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): support self-signed certs in Tableau #6172

Merged
merged 2 commits into from
Oct 13, 2022
Merged

feat(ingest): support self-signed certs in Tableau #6172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
064d17f
feat(ingest): support self-signed certs in Tableau
hsheth2 Oct 11, 2022
f7f652e
allow path
hsheth2 Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/source/tableau.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ class TableauConnectionConfig(ConfigModel):
description="Tableau Site. Always required for Tableau Online. Use emptystring to connect with Default site on Tableau Server.",
)

ssl_verify: Union[bool, str] = Field(
default=True,
description="Whether to verify SSL certificates. If using self-signed certificates, set to false or provide the path to the .pem certificate bundle.",
)

@validator("connect_uri")
def remove_trailing_slash(cls, v):
return config_clean.remove_trailing_slashes(v)
Expand All @@ -144,6 +149,11 @@ def make_tableau_client(self) -> Server:

try:
server = Server(self.connect_uri, use_server_version=True)

# From https://stackoverflow.com/a/50159273/5004662.
server._session.verify = self.ssl_verify
server._session.trust_env = False

server.auth.sign_in(authentication)
return server
except ServerResponseError as e:
Expand Down