-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(queries): [Experimental] Allow customization of # of queries in Query tab via env var #6964
Merged
gabe-lyons
merged 2 commits into
datahub-project:master
from
gabe-lyons:gabe--addingCustomizableQueriesTabCOunts
Jan 6, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
metadata-io/src/main/java/com/linkedin/metadata/config/QueriesTabConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.linkedin.metadata.config; | ||
|
||
import lombok.Data; | ||
|
||
|
||
@Data | ||
public class QueriesTabConfig { | ||
/** | ||
* The number of queries to show on the queries tab. | ||
*/ | ||
public Integer queriesTabResultSize; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ authentication: | |
|
||
# Required if enabled is true! A configurable chain of Authenticators | ||
authenticators: | ||
# Required for authenticating requests with DataHub-issued Access Tokens - best not to remove. | ||
# Required for authenticating requests with DataHub-issued Access Tokens - best not to remove. | ||
- type: com.datahub.authentication.authenticator.DataHubTokenAuthenticator | ||
configs: | ||
# Key used to validate incoming tokens. Should typically be the same as authentication.tokenService.signingKey | ||
|
@@ -28,15 +28,14 @@ authentication: | |
|
||
# Authorization-related configurations. | ||
authorization: | ||
|
||
# Configurations for the default DataHub policies-based authorizer. | ||
defaultAuthorizer: | ||
enabled: ${AUTH_POLICIES_ENABLED:true} | ||
cacheRefreshIntervalSecs: ${POLICY_CACHE_REFRESH_INTERVAL_SECONDS:120} | ||
|
||
ingestion: | ||
enabled: ${UI_INGESTION_ENABLED:true} | ||
defaultCliVersion: '${UI_INGESTION_DEFAULT_CLI_VERSION:@cliMajorVersion@}' | ||
defaultCliVersion: "${UI_INGESTION_DEFAULT_CLI_VERSION:@cliMajorVersion@}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this change intended? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Automatic reformatting to be consistent with the rest of the file |
||
|
||
telemetry: | ||
enabledCli: ${CLI_TELEMETRY_ENABLED:true} | ||
|
@@ -92,6 +91,10 @@ platformAnalytics: | |
enabled: ${DATAHUB_ANALYTICS_ENABLED:true} | ||
|
||
visualConfig: | ||
queriesTab: | ||
# Experimental! This env var is subject to change and may be deprecated in the future. The Queries tab has a larger | ||
# overhaul coming. | ||
queriesTabResultSize: ${REACT_APP_QUERIES_TAB_RESULT_SIZE:5} | ||
assets: | ||
logoUrl: ${REACT_APP_LOGO_URL:/assets/platforms/datahublogo.png} | ||
faviconUrl: ${REACT_APP_FAVICON_URL:/assets/favicon.ico} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic reformatting to be consistent with the rest of the file