Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(transformer): fix names in sample code of 'pattern_add_dataset_domain' #8755

Merged
merged 1 commit into from
Sep 12, 2023
Merged

docs(transformer): fix names in sample code of 'pattern_add_dataset_domain' #8755

merged 1 commit into from
Sep 12, 2023

Conversation

Starkie
Copy link
Contributor

@Starkie Starkie commented Aug 30, 2023

Fixing a small typo in the docs

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 30, 2023
hsheth2
hsheth2 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Starkie

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Sep 12, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 12, 2023

This is a docs-only change, so merging through red CI.

@hsheth2 hsheth2 merged commit 3cc0f76 into datahub-project:master Sep 12, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Starkie @hsheth2