Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/rest-emitter): Do not raise error on retry failure to get better error messages #8837

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat(ingest/rest-emitter): Do not raise error on retry failure to get better error messages #8837

merged 2 commits into from
Sep 13, 2023

Conversation

asikowitz
Copy link
Collaborator

See stack overflow link in the comments

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 13, 2023
@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Sep 13, 2023
@asikowitz asikowitz merged commit 493d315 into datahub-project:master Sep 13, 2023
57 of 58 checks passed
@asikowitz asikowitz deleted the retry-no-raise branch September 13, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asikowitz @hsheth2