feat(ingest/airflow): airflow plugin v2 #8853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
reviewed
Sep 18, 2023
| @@ -18,4 +18,18 @@ def get_provider_info(): | |||
| "package-name": f"{__package_name__}", | |||
| "name": f"{__package_name__}", | |||
There was a problem hiding this comment.
Could probably pick a more human-friendly name here
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/__init__.py
Outdated
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/__init__.py
Outdated
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/_config.py
Show resolved
Hide resolved
|
|
||
| @contextlib.contextmanager | ||
| def _patch_extractors(self): | ||
| with contextlib.ExitStack() as stack: |
There was a problem hiding this comment.
This is pretty cool, kinda reminds me of go defer
Comment on lines
+232
to
+258
| datajob.inlets.extend(original_datajob.inlets) | ||
| datajob.outlets.extend(original_datajob.outlets) | ||
| datajob.fine_grained_lineages.extend(original_datajob.fine_grained_lineages) |
There was a problem hiding this comment.
How come you build up local vars input_urns, output_urns, and fine_grained_lineages above, but then directly update the datajob here? Could we be consistent here?
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/datahub_listener.py
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/datahub_listener.py
Outdated
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/_extractors.py
Show resolved
Hide resolved
|
|
||
| # TODO: Add handling for Airflow mapped tasks using task_instance.map_index | ||
|
|
||
| datajob.emit(self.emitter, callback=self._make_emit_callback()) |
There was a problem hiding this comment.
Doesn't matter for this PR, but I'd prefer something like self.emitter.emit_entity(datajob, callback) to more closely match our mcp emit call
There was a problem hiding this comment.
yup I agree - I'm not super happy with the whole datajob/dataflow interfaces
Would previously see this from the plugin manager. ``` Exception: The package 'acryl-datahub' from setuptools and acryl-datahub-airflow-plugin do not match. Please make sure they are aligned ``` Also fixes + registers hook types
continue making tweaks refactor ti + config refactor get_lineage_config refactoring add in special case handling from backport listener-based plugin fix hooks + add log_level config make logging work more sql fixes start working on combining lineage work with old datahub lineage entities support fine grained lineage support enable_extractors tweak stuff preserve datajob info fix bugs in emitter support threaded exec fix rendering refactoring more refactoring tweak comment review comments mypy fix mypy errors drop python 3.7 fix lint fix lint
hsheth2
force-pushed
the
airflow-plugin
branch
from
b630852
to
b4545cc
Compare
asikowitz
approved these changes
Oct 3, 2023
Comment on lines
+12
to
+14
| - Airflow DAG and tasks, including properties, ownership, and tags. | ||
| - Task run information, including task successes and failures. | ||
| - Manual lineage annotations using `inlets` and `outlets` on Airflow operators. |
There was a problem hiding this comment.
Oh nice these are most of the improvements we were looking for
|
|
||
| The Airflow lineage plugin is only supported with Airflow version >= 2.0.2 or on MWAA with an Airflow version >= 2.0.2. | ||
| There's two actively supported implementations of the plugin, with different Airflow version support. |
There was a problem hiding this comment.
How long do we intend to support both?
There was a problem hiding this comment.
probably for a while - there's no good reason to drop support yet
metadata-ingestion/src/datahub/ingestion/source/sql/sqlalchemy_uri_mapper.py
Outdated
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/tests/integration/test_plugin.py
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/tests/integration/test_plugin.py
Show resolved
Hide resolved
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #8861.Also requires the changes from #8897.Closes #8892.
Closes #6556.
Closes #7809.
Checklist