Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ingest): remove ratelimiter dependency #9008

Merged
merged 3 commits into from
Oct 16, 2023
Merged

build(ingest): remove ratelimiter dependency #9008

merged 3 commits into from
Oct 16, 2023

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 13, 2023
hsheth2
hsheth2 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Not required, but can we add some tests for this?

@mayurinehate
Copy link
Collaborator Author

Code looks good

Not required, but can we add some tests for this?

@hsheth2 I've added a unit test.

@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 16, 2023

Merging as CI failures look unrelated.

@hsheth2 hsheth2 merged commit c81a339 into datahub-project:master Oct 16, 2023
53 of 54 checks passed
@hsheth2 hsheth2 mentioned this pull request Oct 23, 2023
Closed
5 tasks
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @hsheth2 @maggiehays