feat(ingest/mongodb): support stateful ingestion #9118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
TonyOuyangGit
changed the title
hsheth2
reviewed
Oct 27, 2023
| @@ -90,6 +103,10 @@ class MongoDBConfig(PlatformInstanceConfigMixin, EnvConfigMixin): | |||
| # mongodb only supports 16MB as max size for documents. However, if we try to retrieve a larger document it | |||
| # errors out with "16793600" as the maximum size supported. | |||
| maxDocumentSize: Optional[PositiveInt] = Field(default=16793600, description="") | |||
| ingest_data_platform_instance_aspect: Optional[bool] = Field( | |||
| default=False, | |||
There was a problem hiding this comment.
we probably want this to be default true, or at least done automatically if platform_instance is set. don't think it makes sense to make it a config option
|
@TonyOuyangGit one thing - platform_instance support was already added in 8522679 - it looks like this is just doing some refactoring which is great, but I'm going to tweak the PR title accordingly |
hsheth2
changed the title
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
hsheth2
approved these changes
Oct 30, 2023
|
@TonyOuyangGit looks like the mongodb tests need to be updated |
|
@hsheth2 Thank you! Since I refactored to use |
hsheth2
added
the
merge-pending-ci
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the MongoDB ingestion source by adding stateful ingestion and platform instance support and also refactors the existing code to emit
MetadataChangeProposalinstead ofMetadataChangeEventwhich is the current standard way of emitting events.Checklist