feat(policy): enable support for 10k+ policies #9177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
david-leifker
force-pushed
the
policy-fetch-improvements
branch
from
85ab299
to
2ece8d8
Compare
pedro93
reviewed
Nov 5, 2023
metadata-service/auth-impl/src/main/java/com/datahub/authorization/PolicyFetcher.java
Show resolved
Hide resolved
pedro93
reviewed
Nov 5, 2023
metadata-service/auth-impl/src/main/java/com/datahub/authorization/PolicyFetcher.java
Show resolved
Hide resolved
|
Please check the failing CI |
|
CI failures unrelated to the changes in this PR |
pedro93
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching policies was previously limited to 30 policy pages. This PR increases to 1000 by default. Secondly, moving to the scroll API which performs better with deep pagination in the 10k+ policy counts.
The graphql API changes are not included so we're forced to stay compatible with the current start/offset and count by paginating in the background when needed for the UI.
Checklist