Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): set @cliMajorVersion@ correctly #9228

Merged
merged 4 commits into from
Nov 11, 2023
Merged

fix(build): set @cliMajorVersion@ correctly #9228

merged 4 commits into from
Nov 11, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 10, 2023

Fixes #9040.

Also refactors CI to always use fetch-tags: true in checkout.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Nov 10, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Nov 10, 2023
@hsheth2 hsheth2 merged commit 0e3efab into datahub-project:master Nov 11, 2023
40 of 41 checks passed
@hsheth2 hsheth2 deleted the fix-cli-version branch November 11, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green. smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingest fails from SQL Server, ERROR: No matching distribution found for acryl-datahub==@cliMajorVersion@
2 participants
@hsheth2 @david-leifker