feat(recomendations): Make top platforms account only for searchable entities #9240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
jjoyce0510
reviewed
Nov 14, 2023
...s/src/main/java/com/linkedin/metadata/recommendation/candidatesource/TopPlatformsSource.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Nov 14, 2023
...s/src/main/java/com/linkedin/metadata/recommendation/candidatesource/TopPlatformsSource.java
Show resolved
Hide resolved
jjoyce0510
reviewed
Nov 14, 2023
...s/src/main/java/com/linkedin/metadata/recommendation/candidatesource/TopPlatformsSource.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Nov 14, 2023
| @@ -116,6 +117,11 @@ public List<RecommendationContent> getRecommendations(@Nonnull Urn userUrn, | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| protected Filter buildAggregationFilter() { | |||
There was a problem hiding this comment.
can we just have a method that liimits the entity indexes which are used for the query?
then the base class can just return a set of entity type names. what do you think?
There was a problem hiding this comment.
Our Elastic SearchDAO is not prepared to received a set of entity names, it's either a specific one or null (which is all). It would be a greater lift to make multiple requests and 1 to each index and then merge all results or create a regex expression that matches for the set of entities we pass it.
RyanHolstien
approved these changes
Nov 14, 2023
RyanHolstien
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a UI bug where if slack is configured or a custom platform for non-searchable entities is added, then those platforms are not counted towards platforms to be shown above the fold in the homepage.
Checklist