feat(ingest): support stdin in datahub put
#9359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds support for parsing .json files, and refactors some other code.
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Dec 1, 2023
| aspect_value=aspect_obj, | ||
| ) | ||
| click.secho(f"Update succeeded with status {status}", fg="green") | ||
| aspect_obj = load_config_file( |
Comment on lines
+104
to
+105
| allow_remote: bool = True, # TODO: Change the default to False. | ||
| resolve_env_vars: bool = True, # TODO: Change the default to False. |
There was a problem hiding this comment.
What's blocking us from doing this now? Especially allow_remote which is new
There was a problem hiding this comment.
we need to tweak datahub-actions to explicitly set resolve_env_vars=True before we can change the default there
we could change it for allow_remote right now, but didn't want to have too many unrelated changes in this PR right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for parsing .json files, and refactors some other code.
Checklist