Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/powerbi): Allow old parser to parse [db].[schema].[table] table references #9360

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix(ingest/powerbi): Allow old parser to parse [db].[schema].[table] table references #9360

merged 2 commits into from
Dec 4, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 30, 2023
hsheth2
hsheth2 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What exactly are we using the old parser for still?

@hsheth2
Copy link
Collaborator

hsheth2 commented Nov 30, 2023

@asikowitz also there's a mypy failure on 3.7

tests/unit/test_powerbi_parser.py:15: error: Missing named argument "modified_since" for "PowerBiDashboardSourceConfig"  [call-arg]

@asikowitz asikowitz merged commit c0ef728 into datahub-project:master Dec 4, 2023
51 of 52 checks passed
@asikowitz asikowitz deleted the fix-powerbi-parse branch December 4, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@siddiquebagwan-gslab siddiquebagwan-gslab Awaiting requested review from siddiquebagwan-gslab

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asikowitz @hsheth2