fix(ingest/redshift): Identify materialized views properly + fix connection args support #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing extra arg support
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Dec 1, 2023
| @@ -82,7 +82,7 @@ class RedshiftConfig( | |||
| # large Redshift warehouses. As an example, see this query for the columns: | |||
| # https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/blob/60b4db04c1d26071c291aeea52f1dcb5dd8b0eb0/sqlalchemy_redshift/dialect.py#L745. | |||
| scheme: str = Field( | |||
| default="redshift+psycopg2", | |||
| default="redshift+redshift_connector", | |||
There was a problem hiding this comment.
we should call this out in the upgrade guide as a breaking change, since some config that people previously were using may not work anymore (particularly if certain sslmode options no longer work)
Salman-Apptware
pushed a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
…ection args support (datahub-project#9368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify materialized views properly
Fixing extra arg support
Checklist