feat: Deprecation 'Note' changed to Markdown Renderable #9396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Dec 13, 2023
| <DescriptionContainer> | ||
| {expanded || !overLimit ? ( | ||
| <> | ||
| {deprecation?.note && deprecation?.note !== '' && <StyledViewer content={deprecation.note} readOnly />} |
There was a problem hiding this comment.
This makes sense logically but it can be simplified I feel. There is too much nesting and multiple conditionals happening.
Is there any way to simplify this condition?
jjoyce0510
approved these changes
Dec 13, 2023
kushagra-apptware
merged commit e58e2bf
into
datahub-project:master
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
https://linear.app/acryl-data/issue/PRD-847/[datahub-oss]-deprecation-note-should-be-markdown-renderable
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
PRD-847_DeprecationNote.webm