feat(ingest): pydantic v2 compatibility #9434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is still pretty experimental, and all plugins still pin pydantic v1. I'd like the version loosening to go in the 0.12.1.2 release.
If there's issues with our pydantic usage / configs, pydantic throws errors at class creation time. That means that checking
datahub check plugins
should largely help us check if stuff will work. Additionally, all the tests intests/unit/config
pass with both v1 and v2.As of now, GX, feast, and a few other sources hard require pydantic v1. Our main CI tests still install pydantic v1 because it's the lowest common denominator. I did upgrade the Airflow 2.7 test to require pydantic v2. However, it's still not a great way of ensuring that we're compatible with both versions.
The data contracts CLI also continues to use pydantic v1 APIs (with either v1 or v2), since it's not easy to write code that works with both v1 and v2 versions of root models.
Closes #8829, follow up on #9220.
Follow ups
Checklist