Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): improve config loading helpers #9477

Merged
merged 5 commits into from
Jan 3, 2024
Merged

feat(ingest): improve config loading helpers #9477

merged 5 commits into from
Jan 3, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 18, 2023 •
edited
Loading

Also adds secret resolver logic to OSS.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 18, 2023
jjoyce0510
jjoyce0510 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 merged commit f06b5c7 into datahub-project:master Jan 3, 2024
53 checks passed
@hsheth2 hsheth2 deleted the env-vars branch January 3, 2024 20:30
hsheth2 added a commit to acryldata/datahub-actions that referenced this pull request Jan 24, 2024
@hsheth2
fix: upgrade config loading logic to new acryl-datahub
96d2d41 
Was broken by datahub-project/datahub#9477
@hsheth2 hsheth2 mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510