feat(ingest): handle multiline string coercion #9484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
hsheth2
force-pushed
the
cleanup-stuff
branch
from
8d89056
to
97ea816
Compare
hsheth2
changed the title
asikowitz
approved these changes
Dec 21, 2023
| brew install java11 | ||
| brew install --cask zulu8 | ||
| # Install Java | ||
| brew install openjdk@17 |
There was a problem hiding this comment.
This is different than what we're recommending in notion, does that matter?
There was a problem hiding this comment.
it should be fine as long as it's java 17
| @@ -37,9 +37,9 @@ def fetch_urls( | |||
| except Exception as e: | |||
| if attempt < max_retries: | |||
| print(f"Attempt {attempt + 1}/{max_retries}: {e}") | |||
| time.sleep(retry_delay) | |||
| time.sleep(retry_delay * 2**attempt) | |||
There was a problem hiding this comment.
Any reason we don't use requests and its backoff capabilities? Doesn't really matter but might be nice if we ever refactor this
There was a problem hiding this comment.
We didn't want to set up a venv here, so we're using pure python without any external packages
Comment on lines
+2063
to
+2065
| processed_view_files = processed_view_map.setdefault( | ||
| model.connection, set() | ||
| ) |
| assert v.b == "original" | ||
| assert v.d1 == "deprecated" | ||
| assert v.d2 == "deprecated" | ||
| assert any(["d1 is deprecated" in warning for warning in get_global_warnings()]) | ||
| assert any(["d2 is deprecated" in warning for warning in get_global_warnings()]) | ||
|
|
||
| clear_global_warnings() | ||
|
|
||
|
|
||
| def test_multiline_string_fixer(): |
There was a problem hiding this comment.
Can you add a test with a dash in the secret name?
There was a problem hiding this comment.
that will come in a follow up PR - this one doesn't fix that just yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist