Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): change MAU chart to be until last month #9499

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat(analytics): change MAU chart to be until last month #9499

merged 1 commit into from
Dec 21, 2023

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 21, 2023
pedro93
pedro93 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, how was this tested?
wait for green CI as usual

@anshbansal
Copy link
Collaborator Author

Before
image

After
image

@anshbansal anshbansal merged commit a49a435 into master Dec 21, 2023
36 checks passed
@anshbansal anshbansal deleted the ab-change-mau-chart branch December 21, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @pedro93