Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Changed popup text visibility and removed unnecessary code #9611

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fix - Changed popup text visibility and removed unnecessary code #9611

merged 2 commits into from
Jan 12, 2024

Conversation

Kunal-kankriya
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added smoke_test Contains changes related to smoke tests community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 11, 2024
anshbansal
anshbansal requested changes Jan 12, 2024
View reviewed changes
smoke-test/tests/cypress/cypress/e2e/glossary/glossaryTerm.js
cy.waitTextVisible(glossaryTerms.SampleCypressHdfsDataset);
cy.waitTextVisible("of 1");
cy.waitTextVisible(glossaryTerms.hdfsDataset);
cy.waitTextVisible("Cypress 2");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you validating that the search actually worked? This could just be checking for the tag itself. To actually validate that the search worked if you do not wish to reply on number of results then you should go into the entity and then validate the tag exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure will update the validation, thanks!!

smoke-test/tests/cypress/cypress/e2e/glossary/glossaryTerm.js Outdated
cy.waitTextVisible(glossaryTerms.SampleCypressHdfsDataset);
cy.waitTextVisible("of 1");
cy.waitTextVisible(glossaryTerms.hdfsDataset);
cy.waitTextVisible("my hdfs");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not validate functionality. It could be checking for visibility of the search term itself on the page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update it

@anshbansal anshbansal merged commit 600ca1c into datahub-project:master Jan 12, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kunal-kankriya @anshbansal