Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): Add jsonProps to SchemaField type #9622

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix(graphql): Add jsonProps to SchemaField type #9622

merged 1 commit into from
Jan 12, 2024

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Jan 12, 2024

JsonProps is a property of SchemaField in the PDL definitions but it was not surfaced at the graphQL layer. This PR addresses that.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 12, 2024
anshbansal
anshbansal approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait green CI

@pedro93 pedro93 merged commit dc93f2e into master Jan 12, 2024
35 checks passed
@pedro93 pedro93 deleted the ps-add-json-props branch January 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro93 @anshbansal