Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal schema): changes to make internal schema registry more compatible with other schema registries #9636

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented Jan 16, 2024

  • Implementation for the Schema Registry APIs /subjects/{subject}/versions/{version} (getSchemaByVersion) and /subjects/{subject}/versions ( listVersions) which are used by Apache Gobblin to get the latest version of a registered schema. Since schema versions are always 1, these methods are rather straightforward. getSchemaByVersion with version 1 or latest returns the schema registered for a requested subject, otherwise it returns not found. listVersions returns version 1 if a schema registered with the requested subject exists, otherwise it returns not found.
  • Since schemas are not registered with a schemaType, this field is not currently returned when an external Schema Registry is used and is thus removed from the response for compatibility. Additionally, the maxId field should only be returned when requested.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 16, 2024
@david-leifker david-leifker added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jan 16, 2024
@darnaut darnaut merged commit bcaa0ca into master Jan 16, 2024
34 of 35 checks passed
@darnaut darnaut deleted the darnaut-internal-schema-registry-fixes branch January 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants