fix(superset): handle comma in dataset table name #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reserved character
github-actions
bot
added
ingestion
rinzool
force-pushed
the
fix/superset/manage-comma-in-table-name
branch
from
70709d9
to
af9e234
Compare
rinzool
force-pushed
the
fix/superset/manage-comma-in-table-name
branch
from
af9e234
to
c0e247a
Compare
…rinzool/datahub into fix/superset/manage-comma-in-table-name
…rinzool/datahub into fix/superset/manage-comma-in-table-name
hsheth2
reviewed
Jan 18, 2024
| rf"[{''.join(RESERVED_CHARACTERS)}]", | ||
| self.config.reserved_characters_replacement, | ||
| table_name, | ||
| ) |
There was a problem hiding this comment.
if we use our make_dataset_urn helper, it automatically handles this escaping logic. It also has the reserved characters set built in, so we shouldn't need that to be configurable here
There was a problem hiding this comment.
That's nice! Thank you
It's way more simple like that
Thanks a lot for your reviews, I now have a better understanding of Datahub project
rinzool
force-pushed
the
fix/superset/manage-comma-in-table-name
branch
from
70e4814
to
5bfd976
Compare
…rinzool/datahub into fix/superset/manage-comma-in-table-name
rinzool
force-pushed
the
fix/superset/manage-comma-in-table-name
branch
from
07d07b1
to
5855f0b
Compare
hsheth2
added
the
merge-pending-ci
rinzool
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Implementation
Used the
make_dataset_urnfunctionExamples
Output:
A datasource has been created with urn
urn:li:dataset:(urn:li:dataPlatform:athena,athena.some_db.My%2Cvirtual%2Ctable,PROD)