feat(ui) Add structured properties support in the UI #9695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboneil
approved these changes
Jan 23, 2024
samblackk
reviewed
Jan 23, 2024
Comment on lines
287
to
290
| if (error) { | ||
| console.log(`Received an error! ${error}`); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this a remnant of testing? Ideally we shouldn't push errors to the console. If it's for internal capture - let's send to a reporting agent, if it's user-relevant feedback let's show it in an error message in the UI.
There was a problem hiding this comment.
ah no this just got copied over since it's in acryl-main, didn't mean to add it. can remove since we already show the error to the user below it looks like
chriscollins3456
force-pushed
the
cc--prd-949-structured-properties
branch
from
05111c5
to
edb8ce4
Compare
samblackk
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of the recent backend PR where we are now supporting Structured Properties for both base entities and schema fields in the UI. If you use our YAML ingesters to add structured props to entities or schema fields, we will show them in the properties tab or the schema tab. As such, the schema tab now sees a little uplift with a new schema field drawer you can click on to open it up.
Note: this is only supported for datasets to start. We have a ticket and piece of work planned for supporting all entity types with structured props.
Screenshots:
Checklist