feat(ci): check for packages, change location of lint

[anshbansal]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[david-leifker]

Assuming the currently detected issue is valid and would be fixed.

[hsheth2]

Isn’t this still a blocking step? The needs annotation should be on the smoke test job

[anshbansal]

The reason for moving this was because David mentioned it was not a clean approach to add this to setup. This is technically not setup which made sense to me.

It is still blocking and is intended. As it is intended that if smoke test lint is not working we don't want to spend time building docker images at all. I am intentionally doing this as this is CI optimisation to ensure devs get fast feedback instead of waiting for 45 minutes to find out they missed a comma.