Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickstart): remove container_name from compose files #9809

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 9, 2024

Because we have --remove-orphans in the quickstart cli, this should be ok to use on existing quickstarts as well.

Related to #9808

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Because we have `--remove-orphans` in the quickstart cli, this should be
ok to use on existing quickstarts as well.

Related to #9808
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Feb 9, 2024
@hsheth2 hsheth2 changed the title feat(quickstart): remove container_name feat(quickstart): remove container_name from compose files Feb 9, 2024
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Feb 9, 2024
@hsheth2 hsheth2 merged commit 5793467 into master Feb 10, 2024
56 checks passed
@hsheth2 hsheth2 deleted the remove-container-name branch February 10, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants