Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operations): add explain endpoint for search #9832

Merged
merged 5 commits into from
Feb 14, 2024
Merged

feat(operations): add explain endpoint for search #9832

merged 5 commits into from
Feb 14, 2024

Conversation

RyanHolstien
Copy link
Collaborator

@RyanHolstien RyanHolstien commented Feb 13, 2024 •
edited
Loading

Explain endpoint has a limitation of only accepting a single index, so it isn't a perfect replication of our multi-index query. Still useful, but won't be a perfect tool for seeing total ranking comparison.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien added the platform PR-s that make changes to core parts of the platform label Feb 13, 2024
@RyanHolstien RyanHolstien self-assigned this Feb 13, 2024
@github-actions github-actions bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Feb 13, 2024
david-leifker
david-leifker requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permissions check and pagination method

@RyanHolstien RyanHolstien merged commit 2c9fdcd into datahub-project:master Feb 14, 2024
42 checks passed
@RyanHolstien RyanHolstien deleted the feat/searchExplain branch February 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@darnaut darnaut Awaiting requested review from darnaut

Assignees

@RyanHolstien RyanHolstien

Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs platform PR-s that make changes to core parts of the platform product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanHolstien @david-leifker