feat(ingest/dynamoDB): flatten struct fields #9852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…datahub-project#286) This PR implements flattening the `map` attribute type when scanning table items for DynamoDB ingestion. The majority of expanding nested field code logic is adopted from `metadata-ingestion/src/datahub/ingestion/source/schema_inference/object.py`, where it recursively calls `append_schema` for `map` data type field and constructs the field path delimited by `FIELD_DELIMITER`. According to data types supported in DynamoDB in aws [docs](https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.NamingRulesDataTypes.html#HowItWorks.DataTypes), `List` and `Map` type both support recursive structure and since it would add more complexity for expanding list or list of maps, for now we'll only expand `Map` type and will handle expanding list in the future. This PR also adopts a [fix](datahub-project#9612) in MongoDB to sort by `count` and `delimiter_name` when downsampling the table schema Updated `test_dynamodb.py` to add `List` and `Map` type items into test table and `Map` type nested fields are ingested correctly --------- Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
github-actions
bot
added
ingestion
hsheth2
reviewed
Feb 15, 2024
| schema.values(), | ||
| key=lambda x: ( | ||
| -x["count"], | ||
| x["delimited_name"], |
There was a problem hiding this comment.
it looks like we're already sorting a few lines down - can we just do the more sophisticated sort below instead?
There was a problem hiding this comment.
Thank you for your suggestion! That sounds good to me, it looks like same sophisticated sort can apply to MongoDB as well, as this is referred from mongodb.py, I can update this same change in my MongoDB PR as well
5 tasks
hsheth2
approved these changes
Feb 15, 2024
hsheth2
changed the title
dushayntAW
pushed a commit
to dushayntAW/datahub
that referenced
this pull request
Feb 26, 2024
Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements flattening the
mapattribute type when scanning table items for DynamoDB ingestion. The majority of expanding nested field code logic is adopted frommetadata-ingestion/src/datahub/ingestion/source/schema_inference/object.py, where it recursively callsappend_schemaformapdata type field and constructs the field path delimited byFIELD_DELIMITER.According to data types supported in DynamoDB in aws docs,
ListandMaptype both support recursive structure and since it would add more complexity for expanding list or list of maps, for now we'll only expandMaptype and will handle expanding list in the future.This PR also adopts a
fix in MongoDB to sort by
countanddelimiter_namewhen downsampling the table schemaUpdated
test_dynamodb.pyto addListandMaptype items into test table andMaptype nested fields are ingested correctlyChecklist