feat(ui/backend/openapi/docs) : Add support for Business Attributes #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dataset schema field
business-attribute: Created initial version of Business Attribute Scr…
…visa/datahub into business-attributes-v1
Business Attribute Association
Business Attribute related entities and css
Business Attribute Minor Issues
…ng deleted BA from dataset
Cypress Test Cases, Preview Test Case, updating delete BA api, Removi…
# Conflicts: # buildSrc/src/main/java/io/datahubproject/OpenApiEntities.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngineArgs.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/MeResolver.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/deprecation/UpdateDeprecationResolver.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/AddTagsResolver.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/BatchAddTagsResolver.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/DescriptionUtils.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/UpdateDescriptionResolver.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/UpdateNameResolver.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/util/LabelUtils.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/common/mappers/UrnToEntityMapper.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/DatasetType.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/EditableSchemaFieldInfoMapper.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/entitytype/EntityTypeMapper.java # datahub-graphql-core/src/main/resources/entity.graphql # datahub-web-react/src/App.tsx # datahub-web-react/src/Mocks.tsx # datahub-web-react/src/app/entity/Entity.tsx # datahub-web-react/src/app/entity/shared/tabs/Dataset/Schema/SchemaTable.tsx # datahub-web-react/src/app/entity/shared/tabs/Dataset/Schema/utils/useTagsAndTermsRenderer.tsx # datahub-web-react/src/graphql/fragments.graphql # li-utils/src/main/java/com/linkedin/metadata/Constants.java # metadata-io/src/main/java/com/linkedin/metadata/search/utils/ESUtils.java # metadata-io/src/main/java/com/linkedin/metadata/timeline/eventgenerator/EditableSchemaMetadataChangeEventGenerator.java # metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/event/EntityChangeEventGeneratorHook.java # metadata-service/factories/src/main/java/com/linkedin/gms/factory/graphql/GraphQLEngineFactory.java # metadata-service/factories/src/main/java/com/linkedin/gms/factory/timeline/eventgenerator/EntityChangeEventGeneratorRegistryFactory.java # metadata-service/openapi-entity-servlet/src/main/java/io/datahubproject/openapi/delegates/EntityApiDelegateImpl.java # metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java
…tes-feature-flag-implementation Business Attributes: UI Show|Hide Feature Flag Implementation | Modified Test Cases
feat(search): Add SchemaFieldEntity to search functionality
…ustomized-business-attribute-urns Business Attributes: Customized URNs Support for Business Attributes
…es-for-schema-field Business Attributes: Fixed Schema Field Cypress Test Cases
feat(search/schema_field): Update schema field card in search results
…est-implementation Business Attributes: Feature Flag Cypress Test Cases Fix
…ttributes-openapi-changes business-attribute-flag-for-openapi
|
Please update this branch, looking to get the tests passing for merging. LMK if you need some help! |
# Conflicts: # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java # datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/search/SearchUtils.java # datahub-web-react/src/app/entity/shared/tabs/Dataset/AccessManagement/__tests__/AccessManagement.test.ts
|
Hi @david-leifker, branch has been updated and conflicts has been resolved. Still 3 tests are failing and we are not sure about the reason as they are not seems to be related with our functionality. Please suggest |
|
|
||
| getCustomCardUrlPath = () => PageRoutes.BUSINESS_ATTRIBUTE; | ||
|
|
||
| isBrowseEnabled = () => true; |
There was a problem hiding this comment.
i actually believe we want this to be false since the browse sidebar is not built to browse for business attribute entities. and this being true is what is actually breaking the failing frontend tests currently
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…atahub-project#9863) Co-authored-by: ppurswan <ppurswan@visa.com> Co-authored-by: PrithviVISA <140717353+PrithviVISA@users.noreply.github.com> Co-authored-by: aditigup <aditigup@visa.com> Co-authored-by: Bharti, Aakash <aabharti@visa.com> Co-authored-by: Singh, Himanshu <hisingh@visa.com> Co-authored-by: Shukla, Amit <amishukl@visa.com> Co-authored-by: Kartikey Khandelwal <kakhande@visa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the implementation for the following RFC
datahub-project/rfcs#6
Screenshots:
Checklist