-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add option to add picture link for groups #9882
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1302c20
add pictureLink in updateGroupInfo
akarsh991 99ee121
add pictureLink
akarsh991 1e96f63
add pictureLink for updategroupinfo
akarsh991 422ee65
backend read/write changes for PRD-982
akarsh991 90bef3d
Added backend logic for pictureLink
akarsh991 a287f93
cypress test case changes
akarsh991 47ceb76
Cypress test case changes
akarsh991 e15170e
cypress test case changes
akarsh991 8ab08fc
reset yarn.lock
akarsh991 8774675
Merge branch 'datahub-project:master' into feat/PRD-982
akarsh991 dac6a82
add picturelink to group
akarsh991 a39e404
Merge branch 'feat/PRD-982' of https://github.com/apptware991/datahub…
akarsh991 229d767
feat(ui/groups): add ability to set logos for datahub groups
gaurav2733 ac1e4a9
added editableproperties in caching
gaurav2733 ba15514
Merge branch 'master' into feat/PRD-982
gaurav2733 299089a
fix lint issues
akarsh991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens for existing cases where picture link might not be set? Have you tested opening the UI for an existing group?