Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add option to add picture link for groups #9882

Merged
merged 16 commits into from
Mar 5, 2024
Merged

feat(ui): add option to add picture link for groups #9882

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1302c20
add pictureLink in updateGroupInfo
akarsh991 Feb 19, 2024
99ee121
add pictureLink
akarsh991 Feb 19, 2024
1e96f63
add pictureLink for updategroupinfo
akarsh991 Feb 19, 2024
422ee65
backend read/write changes for PRD-982
akarsh991 Feb 20, 2024
90bef3d
Added backend logic for pictureLink
akarsh991 Feb 20, 2024
a287f93
cypress test case changes
akarsh991 Feb 27, 2024
47ceb76
Cypress test case changes
akarsh991 Feb 28, 2024
e15170e
cypress test case changes
akarsh991 Feb 28, 2024
8ab08fc
reset yarn.lock
akarsh991 Feb 28, 2024
8774675
Merge branch 'datahub-project:master' into feat/PRD-982
akarsh991 Feb 28, 2024
dac6a82
add picturelink to group
akarsh991 Feb 29, 2024
a39e404
Merge branch 'feat/PRD-982' of https://github.com/apptware991/datahub…
akarsh991 Feb 29, 2024
229d767
feat(ui/groups): add ability to set logos for datahub groups
gaurav2733 Feb 22, 2024
ac1e4a9
added editableproperties in caching
gaurav2733 Feb 23, 2024
ba15514
Merge branch 'master' into feat/PRD-982
gaurav2733 Mar 5, 2024
299089a
fix lint issues
akarsh991 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 31 additions & 32 deletions smoke-test/tests/cypress/cypress/e2e/settings/managing_groups.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,38 +64,37 @@ describe("create and manage group", () => {
});

it("update group info", () => {
var expected_name = Cypress.env('ADMIN_USERNAME');
cy.loginWithCredentials();
cy.visit("/settings/identities/groups");
cy.clickOptionWithText(group_name);
cy.contains(group_name).find('[aria-label="Edit"]').click();
cy.focused().clear().type(`Test group EDITED ${test_id}{enter}`);
cy.waitTextVisible("Name Updated");
cy.contains(`Test group EDITED ${test_id}`).should("be.visible");
cy.get('[data-testid="edit-icon"]').click();
cy.waitTextVisible("Edit Description");
cy.get("#description").should("be.visible").type(" EDITED");
cy.get("#updateGroupButton").click();
cy.waitTextVisible("Changes saved.");
cy.contains("Test group description EDITED").should("be.visible");
cy.clickOptionWithText("Add Owners");
cy.contains("Search for users or groups...").click({ force: true });
cy.focused().type(expected_name);
cy.get(".ant-select-item-option").contains(expected_name, { matchCase: false }).click();
cy.focused().blur();
cy.contains(expected_name, { matchCase: false }).should("have.length", 1);
cy.get('[role="dialog"] button').contains("Done").click();
cy.waitTextVisible("Owners Added");
cy.contains(expected_name, { matchCase: false }).should("be.visible");
cy.clickOptionWithText("Edit Group");
cy.waitTextVisible("Edit Profile");
cy.get("#email").type(`${test_id}@testemail.com`);
cy.get("#slack").type(`#${test_id}`);
cy.clickOptionWithText("Save Changes");
cy.waitTextVisible("Changes saved.");
cy.waitTextVisible(`${test_id}@testemail.com`);
cy.waitTextVisible(`#${test_id}`);
});
cy.loginWithCredentials();
cy.visit("/settings/identities/groups");
cy.clickOptionWithText(group_name);
cy.contains(group_name).find('[aria-label="Edit"]').click();
cy.focused().clear().type(`Test group EDITED ${test_id}{enter}`);
cy.waitTextVisible("Name Updated");
cy.contains(`Test group EDITED ${test_id}`).should("be.visible");
cy.get('[data-testid="edit-icon"]').click();
cy.waitTextVisible("Edit Description");
cy.get("#description").should("be.visible").type(" EDITED");
cy.get("#updateGroupButton").click();
cy.waitTextVisible("Changes saved.");
cy.contains("Test group description EDITED").should("be.visible");
cy.clickOptionWithText("Add Owners");
cy.get('[id="owner"]').click({ force: true });
cy.focused().type(username);
cy.get(".ant-select-item-option").contains(username, { matchCase: false }).click();
cy.focused().blur();
cy.contains(username, { matchCase: false }).should("have.length", 1);
cy.get('[role="dialog"] button').contains("Done").click();
cy.waitTextVisible("Owners Added");
cy.contains(username, { matchCase: false }).should("be.visible");
cy.clickOptionWithText("Edit Group");
cy.waitTextVisible("Edit Profile");
cy.get("#email").type(`${test_id}@testemail.com`);
cy.get("#slack").type(`#${test_id}`);
cy.clickOptionWithText("Save Changes");
cy.waitTextVisible("Changes saved.");
cy.waitTextVisible(`${test_id}@testemail.com`);
cy.waitTextVisible(`#${test_id}`);
});
anshbansal marked this conversation as resolved.
Show resolved Hide resolved

it("test user verify group participation", () => {
cy.loginWithCredentials();
Expand Down
4 changes: 2 additions & 2 deletions smoke-test/tests/cypress/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ Cypress.Commands.add("loginWithCredentials", (username, password) => {
cy.get('input[data-testid=username]').type(username);
cy.get('input[data-testid=password]').type(password);
} else {
cy.get('input[data-testid=username]').type(Cypress.env('ADMIN_USERNAME'));
cy.get('input[data-testid=password]').type(Cypress.env('ADMIN_PASSWORD'));
cy.get('input[data-testid=username]').type('datahub');
cy.get('input[data-testid=password]').type('datahub');
anshbansal marked this conversation as resolved.
Show resolved Hide resolved
}
cy.contains('Sign In').click();
cy.contains('Welcome back');
Expand Down
Loading
Loading