feat(ui): add option to add picture link for groups

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/corpgroup/CorpGroupType.java

@@ -7,6 +7,7 @@
 import com.datahub.authorization.DisjunctivePrivilegeGroup;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
+import com.linkedin.common.url.Url;
 import com.linkedin.common.urn.Urn;
 import com.linkedin.common.urn.UrnUtils;
 import com.linkedin.data.template.RecordTemplate;
@@ -232,6 +233,9 @@ private RecordTemplate mapCorpGroupEditableInfo(
     if (input.getEmail() != null) {
       result.setEmail(input.getEmail());
     }
+    if (input.getPictureLink() != null) {
+      result.setPictureLink(new Url(input.getPictureLink()));
+    }
     return result;
   }
 }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/corpgroup/mappers/CorpGroupEditablePropertiesMapper.java

@@ -1,8 +1,11 @@
 package com.linkedin.datahub.graphql.types.corpgroup.mappers;
 
+import com.linkedin.common.url.Url;
 import com.linkedin.data.template.GetMode;
+import com.linkedin.data.template.RecordTemplate;
 import com.linkedin.datahub.graphql.generated.CorpGroupEditableProperties;
 import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
+import java.util.Objects;
 import javax.annotation.Nonnull;
 
 /**
@@ -29,6 +32,9 @@ public CorpGroupEditableProperties apply(
     result.setDescription(corpGroupEditableInfo.getDescription(GetMode.DEFAULT));
     result.setSlack(corpGroupEditableInfo.getSlack(GetMode.DEFAULT));
     result.setEmail(corpGroupEditableInfo.getEmail(GetMode.DEFAULT));
+    result.setPictureLink((Objects.requireNonNull(
+        corpGroupEditableInfo.getPictureLink(GetMode.DEFAULT))).toString());
+
     return result;
   }
 }

datahub-graphql-core/src/main/resources/entity.graphql

@@ -4070,6 +4070,11 @@ type CorpGroupEditableProperties {
   Email address for the group
   """
   email: String
+
+  """ 
+  A URL which points to a picture which user wants to set as a profile photo
+  """
+  pictureLink: String
 }
 
 """
@@ -4090,6 +4095,11 @@ input CorpGroupUpdateInput {
   Email address for the group
   """
   email: String
+
+  """
+  A URL which points to a picture which user wants to set as a profile photo
+  """
+  pictureLink: String
 }
 
 """

datahub-web-react/src/graphql/group.graphql

@@ -17,6 +17,7 @@ query getGroup($urn: String!, $membersCount: Int!) {
             description
             slack
             email
+            pictureLink
         }
         properties {
             displayName

smoke-test/tests/cypress/cypress/e2e/settings/managing_groups.js

@@ -64,38 +64,37 @@ describe("create and manage group", () => {
     });
 
     it("update group info", () => {
-        var expected_name = Cypress.env('ADMIN_USERNAME');
-        cy.loginWithCredentials();
-        cy.visit("/settings/identities/groups");
-        cy.clickOptionWithText(group_name);
-        cy.contains(group_name).find('[aria-label="Edit"]').click();
-        cy.focused().clear().type(`Test group EDITED ${test_id}{enter}`);
-        cy.waitTextVisible("Name Updated");
-        cy.contains(`Test group EDITED ${test_id}`).should("be.visible");
-        cy.get('[data-testid="edit-icon"]').click();
-        cy.waitTextVisible("Edit Description");
-        cy.get("#description").should("be.visible").type(" EDITED");
-        cy.get("#updateGroupButton").click();
-        cy.waitTextVisible("Changes saved.");
-        cy.contains("Test group description EDITED").should("be.visible");
-        cy.clickOptionWithText("Add Owners");
-        cy.contains("Search for users or groups...").click({ force: true });
-        cy.focused().type(expected_name);
-        cy.get(".ant-select-item-option").contains(expected_name, { matchCase: false }).click();
-        cy.focused().blur();
-        cy.contains(expected_name, { matchCase: false }).should("have.length", 1);
-        cy.get('[role="dialog"] button').contains("Done").click();
-        cy.waitTextVisible("Owners Added");
-        cy.contains(expected_name, { matchCase: false }).should("be.visible");
-        cy.clickOptionWithText("Edit Group");
-        cy.waitTextVisible("Edit Profile");
-        cy.get("#email").type(`${test_id}@testemail.com`);
-        cy.get("#slack").type(`#${test_id}`);
-        cy.clickOptionWithText("Save Changes");
-        cy.waitTextVisible("Changes saved.");
-        cy.waitTextVisible(`${test_id}@testemail.com`);
-        cy.waitTextVisible(`#${test_id}`);
-    });
+            cy.loginWithCredentials();
+            cy.visit("/settings/identities/groups");
+            cy.clickOptionWithText(group_name);
+            cy.contains(group_name).find('[aria-label="Edit"]').click();
+            cy.focused().clear().type(`Test group EDITED ${test_id}{enter}`);
+            cy.waitTextVisible("Name Updated");
+            cy.contains(`Test group EDITED ${test_id}`).should("be.visible");
+            cy.get('[data-testid="edit-icon"]').click();
+            cy.waitTextVisible("Edit Description");
+            cy.get("#description").should("be.visible").type(" EDITED");
+            cy.get("#updateGroupButton").click();
+            cy.waitTextVisible("Changes saved.");
+            cy.contains("Test group description EDITED").should("be.visible");
+            cy.clickOptionWithText("Add Owners");
+            cy.get('[id="owner"]').click({ force: true });
+            cy.focused().type(username);
+            cy.get(".ant-select-item-option").contains(username, { matchCase: false }).click();
+            cy.focused().blur();
+            cy.contains(username, { matchCase: false }).should("have.length", 1);
+            cy.get('[role="dialog"] button').contains("Done").click();
+            cy.waitTextVisible("Owners Added");
+            cy.contains(username, { matchCase: false }).should("be.visible");
+            cy.clickOptionWithText("Edit Group");
+            cy.waitTextVisible("Edit Profile");
+            cy.get("#email").type(`${test_id}@testemail.com`);
+            cy.get("#slack").type(`#${test_id}`);
+            cy.clickOptionWithText("Save Changes");
+            cy.waitTextVisible("Changes saved.");
+            cy.waitTextVisible(`${test_id}@testemail.com`);
+            cy.waitTextVisible(`#${test_id}`);
+        });
 
     it("test user verify group participation", () => {
         cy.loginWithCredentials();

smoke-test/tests/cypress/cypress/support/commands.js

@@ -40,8 +40,8 @@ Cypress.Commands.add("loginWithCredentials", (username, password) => {
     cy.get('input[data-testid=username]').type(username);
     cy.get('input[data-testid=password]').type(password);
   } else {
-    cy.get('input[data-testid=username]').type(Cypress.env('ADMIN_USERNAME'));
-    cy.get('input[data-testid=password]').type(Cypress.env('ADMIN_PASSWORD'));
+    cy.get('input[data-testid=username]').type('datahub');
+    cy.get('input[data-testid=password]').type('datahub');
   }
   cy.contains('Sign In').click();
   cy.contains('Welcome back');