Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): document remote for ingest deploy #9897

Merged
merged 4 commits into from
Feb 21, 2024
Merged

docs(ingest): document remote for ingest deploy #9897

merged 4 commits into from
Feb 21, 2024

Conversation

gabe-lyons
Copy link
Contributor

Saw some confusion from users of this. It's unclear since datahub ingest -c will use the sink in the recipe, but ingest deploy will prefer the sink of the CLI.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Feb 21, 2024
hsheth2
hsheth2 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Feb 21, 2024
@gabe-lyons gabe-lyons enabled auto-merge (squash) February 21, 2024 21:58
@david-leifker david-leifker merged commit 3b88ebb into master Feb 21, 2024
1 check passed
@david-leifker david-leifker deleted the gabe-lyons-document-ingest-deplpoy branch February 21, 2024 22:34
dushayntAW pushed a commit to dushayntAW/datahub that referenced this pull request Feb 26, 2024
@gabe-lyons @dushayntAW
docs(ingest): document remote for ingest deploy (datahub-project#9897)
1821dc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @hsheth2 @david-leifker