Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui/groups): add ability to set logos for datahub groups #9905

Closed
wants to merge 2 commits into from
Closed

feat(ui/groups): add ability to set logos for datahub groups #9905

wants to merge 2 commits into from

Conversation

gaurav2733
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@gaurav2733 gaurav2733 marked this pull request as draft February 22, 2024 13:18
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 22, 2024
@asikowitz
Copy link
Collaborator

Thanks for your contribution. Are you still working on this or is this ready for review?

@gaurav2733
Copy link
Contributor Author

gaurav2733 commented Feb 22, 2024 •
edited
Loading

The backend PR not merged yet to master, so testing is pending from my side.Once testing is done i will move it to ready for review

@asikowitz asikowitz removed the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 22, 2024
@anshbansal
Copy link
Collaborator

anshbansal commented Feb 28, 2024 •
edited
Loading

Closing in favor of #9882 where the frontend changes will be added

@anshbansal anshbansal closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav2733 @asikowitz @anshbansal