Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(patch): refactor cll patch #9922

Merged
merged 5 commits into from
Feb 27, 2024
Merged

feat(patch): refactor cll patch #9922

merged 5 commits into from
Feb 27, 2024

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien self-assigned this Feb 26, 2024
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 26, 2024
david-leifker
david-leifker approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general changes seem fine at a high level, but I am definitely not knowledge-able enough to evaluate the intricacies of fine grained lineage here.

@RyanHolstien RyanHolstien merged commit ddf0b7d into datahub-project:master Feb 27, 2024
57 checks passed
@RyanHolstien RyanHolstien deleted the refactor-cll-patch branch February 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@treff7es treff7es Awaiting requested review from treff7es

@darnaut darnaut Awaiting requested review from darnaut

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees

@RyanHolstien RyanHolstien

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanHolstien @david-leifker @hsheth2