-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/snowflake): generate query nodes for snowflake #9966
Merged
hsheth2
merged 4 commits into
datahub-project:master
from
mayurinehate:master+ing-518-snowflake-query-node
Mar 6, 2024
Merged
feat(ingest/snowflake): generate query nodes for snowflake #9966
hsheth2
merged 4 commits into
datahub-project:master
from
mayurinehate:master+ing-518-snowflake-query-node
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other noteworthy changes: 1. Removed view lineage fallback for views with failed sql parsing 2. Populated timestamp in Upstream class same as query time
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
community-contribution
PR or Issue raised by member(s) of DataHub Community
labels
Mar 1, 2024
hsheth2
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, left a few minor suggestions
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_lineage_v2.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Show resolved
Hide resolved
hsheth2
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lint issues should be fixed by #9976 |
hsheth2
added
the
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
label
Mar 4, 2024
dushayntAW
pushed a commit
to dushayntAW/datahub
that referenced
this pull request
Mar 7, 2024
…roject#9966) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
ingestion
PR or Issue related to the ingestion of metadata
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other noteworthy changes:
Checklist