Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/tableau): Modify IS_UNSUPPORTED_CUSTOM_SQL type from False -> True #9973

Closed
wants to merge 6 commits into from
Closed

fix(ingest/tableau): Modify IS_UNSUPPORTED_CUSTOM_SQL type from False -> True #9973

wants to merge 6 commits into from

Conversation

KaYunKIM
Copy link
Contributor

@KaYunKIM KaYunKIM commented Mar 4, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 4, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 18, 2024

@KaYunKIM can you elaborate on the motivation behind this PR?

Also, note that this PR may already do what you're looking for #9838

@KaYunKIM
Copy link
Contributor Author

KaYunKIM commented Mar 28, 2024 •
edited
Loading

@hsheth2 Yes finally! I guess this is exactly what I was looking for!
I can try with the updated code. Thanks a lot!

@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 10, 2024

@KaYunKIM going to close this out as superseded by #9838 - let me know if there's still additional changes we want to make here.

@hsheth2 hsheth2 closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaYunKIM @hsheth2