Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add loading spin to access management table #9974

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat(ui): add loading spin to access management table #9974

merged 2 commits into from
Mar 5, 2024

Conversation

filipe-caetano-ovo
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Before:
access_mgmt_before_spin-ezgif com-video-to-gif-converter

After:
access_mgmt_after_spin-ezgif com-video-to-gif-converter

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 4, 2024
chriscollins3456
chriscollins3456 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice looks good! thanks for this

@pedro93 pedro93 merged commit a0efb9d into datahub-project:master Mar 5, 2024
36 checks passed
dushayntAW pushed a commit to dushayntAW/datahub that referenced this pull request Mar 7, 2024
@filipe-caetano-ovo @dushayntAW
feat(ui): add loading spin to access management table (datahub-projec…
30bbc37 
…t#9974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipe-caetano-ovo @chriscollins3456 @pedro93