Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add External Storage (File) #197

Merged
merged 28 commits into from
Mar 31, 2020
Merged

Conversation

guzman-raphael
Copy link
Collaborator

Fix #143

Supports new configuration

{
  "blob.cache": "/tmp/cache",
  "stores": {
        "local": {
            "datajoint_type": "blob",
            "protocol": "file",
            "location": "/tmp/base",
            "subfolding": [
                3,
                4
            ]
   }
}

And is backward compatible to prior configuration

{
  "cache": "/tmp/cache",
  "stores": {
        "local": {
            "protocol": "file",
            "location": "/tmp/base",
            "subfolding": [
                3,
                4
            ]
   }
}

See python documentation (for now)
https://docs.datajoint.io/python/admin/5-blob-config.html#configuration

Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

+dj/+internal/Declare.m Outdated Show resolved Hide resolved
setupDJ.m Outdated
@@ -27,7 +27,7 @@ function setupDJ(skipPathAddition, force)
fprintf('mym missing. Downloading...\n')
target = fullfile(base, 'mym.zip');
% mymURL = 'https://github.com/datajoint/mym/archive/master.zip';
mymURL = 'https://github.com/datajoint/mym/archive/external-storage.zip';
mymURL = 'https://github.com/guzman-raphael/mym/archive/ext-serialize.zip';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change back to datajoint on the master branch.

date : datetime
number : float
blob : longblob
string=null : varchar(30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string=null : varchar(30)
string='' : varchar(30)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants