Fix SQL argument growth condition #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checking against master).
Fix SQL argument growth condition
Remove debug data
guzman-raphael
requested review from
dimitri-yatsenko and
eywalker
and removed request for
dimitri-yatsenko and
eywalker
+dj/Relvar.m
Outdated
| @@ -215,35 +215,36 @@ function insert(self, tuples, command) | |||
| % value: <var> Processed, in-place value ready for insert. | |||
| % placeholder:<string> Placeholder for argument substitution. | |||
| % attr_idx: <num> Attribute order index. | |||
| if header.attributes(attr_idx).isString | |||
| if isempty(value) || (header.attributes(attr_idx).isNumeric && isnan(value)) | |||
There was a problem hiding this comment.
What about an empty string? I will review this more carefully later tonight. But keep in mind that empty strings are distinct from null. This looks as though empty strings will be entered as null.
There was a problem hiding this comment.
Good point, I will review/test it once more too. How are nulls expected to return from a fetch for the common datatypes?
Update logic to be more directly mindful of placeholder substitution
Simplify logic
eywalker
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #217