Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+= +dj/kill_quick.m: programmatic kill function (#251) #266

Merged
merged 8 commits into from
Nov 12, 2020
Merged

+= +dj/kill_quick.m: programmatic kill function (#251) #266

merged 8 commits into from
Nov 12, 2020

Conversation

ixcat
Copy link
Contributor

@ixcat ixcat commented Aug 8, 2020

see #251 - based on top of #248 - draft until #248 merged

@ixcat ixcat marked this pull request as draft August 8, 2020 01:24
@ixcat ixcat marked this pull request as ready for review October 9, 2020 16:16
@ixcat
Copy link
Contributor Author

ixcat commented Oct 9, 2020

requires #248 merged 1st

Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left feedback based on recent issues we had in datajoint-python for MySQL8 tests. Also, would you update dj.kill to match as well?

+dj/kill_quick.m Outdated Show resolved Hide resolved
+dj/kill_quick.m Outdated Show resolved Hide resolved
@guzman-raphael guzman-raphael merged commit d7f7223 into datajoint:stage Nov 12, 2020
@guzman-raphael guzman-raphael mentioned this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants