Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headless password prompt update (see #278) #280

Merged
merged 2 commits into from
Oct 9, 2020
Merged

headless password prompt update (see #278) #280

merged 2 commits into from
Oct 9, 2020

Conversation

ixcat
Copy link
Contributor

@ixcat ixcat commented Aug 20, 2020 •
edited
Loading

see #278

dimitri-yatsenko
dimitri-yatsenko reviewed Aug 21, 2020
View reviewed changes
+dj/conn.m Outdated Show resolved Hide resolved
@guzman-raphael guzman-raphael self-assigned this Aug 21, 2020
@ixcat
Copy link
Contributor Author

ixcat commented Sep 18, 2020

^ discussion of 'gui available but running nodesktop, should popup or not' resolved - will assume nodesktop means nogui.

@ixcat ixcat marked this pull request as ready for review September 18, 2020 17:41
guzman-raphael
guzman-raphael requested changes Oct 9, 2020
View reviewed changes
Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you re-point it to stage?

@ixcat ixcat changed the base branch from master to stage October 9, 2020 18:31
@guzman-raphael guzman-raphael merged commit c9597f0 into datajoint:stage Oct 9, 2020
@guzman-raphael guzman-raphael mentioned this pull request Oct 13, 2020
Merged
@guzman-raphael guzman-raphael mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitri-yatsenko dimitri-yatsenko dimitri-yatsenko left review comments

@guzman-raphael guzman-raphael guzman-raphael approved these changes

Assignees

@guzman-raphael guzman-raphael

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ixcat @dimitri-yatsenko @guzman-raphael