Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing image from pydev to djtest #1012

Merged
merged 37 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5dcf630
pytest support
A-Baji Apr 12, 2022
c617834
disable 3.10 8.0
A-Baji Apr 12, 2022
3130795
disable 3.10
A-Baji Apr 12, 2022
6d550a1
re-add coveralls env
A-Baji Apr 12, 2022
0f04ebc
disable 3.10, 3.9
A-Baji Apr 12, 2022
d5778b3
enable 3.10, 3.9
A-Baji Apr 12, 2022
360d27c
bump nginx
A-Baji Apr 12, 2022
2549850
revert dockerfile
A-Baji Apr 12, 2022
a34c61a
dockerfile
A-Baji Apr 12, 2022
a3010d5
check with pydev
A-Baji Apr 12, 2022
ee49587
disable 3.10,3.9
A-Baji Apr 12, 2022
903b088
idk
A-Baji Apr 12, 2022
0429987
bump minio?
A-Baji Apr 12, 2022
4cf592f
revert mminio
A-Baji Apr 12, 2022
7c580d2
fix host uid
A-Baji Apr 12, 2022
f079bf2
remove -r flag
A-Baji Apr 13, 2022
99f3010
add git to apk reqs
A-Baji Apr 15, 2022
ca98050
remove git from apk requirements
A-Baji Apr 20, 2022
fdf35c3
comment out 3.10 check
A-Baji Apr 20, 2022
fbf6ba1
fix workflow
A-Baji Apr 20, 2022
4c55712
cleanup workflow
A-Baji Apr 20, 2022
dee6a98
update readme
A-Baji Apr 20, 2022
dad27e7
docs
A-Baji Apr 20, 2022
21f7ad1
Merge branch 'master' of https://github.com/datajoint/datajoint-pytho…
A-Baji May 13, 2022
3d0ceaa
Fix merge conflicts.
guzman-raphael Feb 3, 2023
2c433fd
Update GHA.
guzman-raphael Feb 4, 2023
6aa4805
Remove py311 test since nosetests incompatible.
guzman-raphael Feb 4, 2023
9e89f2d
Add docker image publish step to DockerHub.
guzman-raphael Feb 4, 2023
086674d
Adjust comment wording.
guzman-raphael Feb 4, 2023
3e05cb7
Adjust comment wording again.
guzman-raphael Feb 4, 2023
cc0b744
Fix version parsing.
guzman-raphael Feb 4, 2023
659714e
Remove py310 test since nosetests doesn't support.
guzman-raphael Feb 4, 2023
00456da
Fix backward-incompatible numpy change.
guzman-raphael Feb 4, 2023
0c4ce16
Adjust styling.
guzman-raphael Feb 4, 2023
79e1bd7
Fix styling in tests.
guzman-raphael Feb 4, 2023
7ac30db
Add reasonable defaults for packaging environment.
guzman-raphael Feb 4, 2023
9823355
Merge pull request #1 from guzman-raphael/switch-to-djtest
A-Baji Feb 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
py_ver: ["3.8"]
# py_ver: ["3.10"]
py_ver: ["3.9"]
mysql_ver: ["8.0", "5.7"]
include:
- py_ver: "3.7"
# - py_ver: "3.9"
# mysql_ver: "5.7"
- py_ver: "3.8"
mysql_ver: "5.7"
- py_ver: "3.6"
- py_ver: "3.7"
mysql_ver: "5.7"
steps:
- uses: actions/checkout@v2
Expand All @@ -52,15 +55,13 @@ jobs:
run: flake8 datajoint --count --select=E9,F63,F7,F82 --show-source --statistics
- name: Run primary tests
env:
UID: "1001"
HOST_UID: "1001"
GID: "121"
PY_VER: ${{matrix.py_ver}}
MYSQL_VER: ${{matrix.mysql_ver}}
ALPINE_VER: "3.10"
DISTRO: alpine
MINIO_VER: RELEASE.2021-09-03T03-56-13Z
COMPOSE_HTTP_TIMEOUT: "120"
COVERALLS_SERVICE_NAME: travis-ci
COVERALLS_REPO_TOKEN: fd0BoXG46TPReEem0uMy7BJO5j0w1MQiY
run: docker-compose -f LNX-docker-compose.yml up --build --exit-code-from app
- name: Run style tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ notebook
__main__.py
jupyter_custom.js
apk_requirements.txt
.eggs
.eggs
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Release notes

### 0.13.5 -- TBA
* Update - Switch testing image from `pydev` to `djtest` PR #1012

### 0.13.4 -- March, 28 2022
* Add - Allow reading blobs produced by legacy 32-bit compiled mYm library for matlab. PR #995
* Bugfix - Add missing `jobs` argument for multiprocessing PR #997
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM datajoint/pydev
FROM datajoint/djbase

COPY --chown=dja . /tmp/src
RUN pip install --user /tmp/src && \
COPY --chown=anaconda:anaconda . /tmp/src
RUN pip install --no-cache-dir /tmp/src && \
rm -rf /tmp/src
12 changes: 5 additions & 7 deletions LNX-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ services:
interval: 1s
fakeservices.datajoint.io:
<<: *net
image: datajoint/nginx:v0.1.1
image: datajoint/nginx:v0.2.0
environment:
- ADD_db_TYPE=DATABASE
- ADD_db_ENDPOINT=db:3306
Expand All @@ -51,7 +51,7 @@ services:
condition: service_healthy
app:
<<: *net
image: datajoint/pydev:${PY_VER}-alpine${ALPINE_VER}
image: datajoint/djtest:py${PY_VER}-${DISTRO}
depends_on:
fakeservices.datajoint.io:
condition: service_healthy
Expand All @@ -69,26 +69,24 @@ services:
- PYTHON_USER=dja
- JUPYTER_PASSWORD=datajoint
- DISPLAY
- COVERALLS_SERVICE_NAME
- COVERALLS_REPO_TOKEN
working_dir: /src
command:
- sh
- -c
- |
set -e
pip install --user -r test_requirements.txt
pip install --user nose nose-cov
pip install -e .
pip freeze | grep datajoint
nosetests -vsw tests --with-coverage --cover-package=datajoint
coveralls
# jupyter notebook
# ports:
# - "8888:8888"
user: ${UID}:${GID}
user: ${HOST_UID}:anaconda
volumes:
- .:/src
- /tmp/.X11-unix:/tmp/.X11-unix:rw
# - ./apk_requirements.txt:/tmp/apk_requirements.txt
# - ./notebooks:/home/dja/notebooks
networks:
main:
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ More details in [docs-api/README.md](docs-api/README.md).

* Create an `.env` with desired development environment values e.g.
``` sh
PY_VER=3.7
ALPINE_VER=3.10
PY_VER=3.9
MYSQL_VER=5.7
MINIO_VER=RELEASE.2021-09-03T03-56-13Z
UID=1000
DISTRO=alpine
MINIO_VER=RELEASE.2022-01-03T18-22-58Z
HOST_UID=1000
GID=1000
```
* `cp local-docker-compose.yml docker-compose.yml`
Expand Down
1 change: 1 addition & 0 deletions apk_requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
make
4 changes: 4 additions & 0 deletions docs-parts/intro/Releases_lang1.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
0.13.5 -- TBA
----------------------
* Update - Switch testing image from `pydev` to `djtest` PR #1012

0.13.4 -- March 28, 2022
----------------------
* Add - Allow reading blobs produced by legacy 32-bit compiled mYm library for matlab. PR #995
Expand Down
8 changes: 4 additions & 4 deletions local-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ services:
interval: 1s
fakeservices.datajoint.io:
<<: *net
image: datajoint/nginx:v0.1.1
image: datajoint/nginx:v0.2.0
environment:
- ADD_db_TYPE=DATABASE
- ADD_db_ENDPOINT=db:3306
Expand All @@ -57,7 +57,7 @@ services:
condition: service_healthy
app:
<<: *net
image: datajoint/pydev:${PY_VER}-alpine${ALPINE_VER}
image: datajoint/djtest:py${PY_VER}-${DISTRO}
depends_on:
fakeservices.datajoint.io:
condition: service_healthy
Expand All @@ -82,7 +82,7 @@ services:
- -c
- |
set -e
pip install --user nose nose-cov coveralls flake8 ptvsd black
pip install --user nose nose-cov
pip install -e .
pip freeze | grep datajoint
## You may run the below tests once sh'ed into container i.e. docker exec -it datajoint-python_app_1 sh
Expand All @@ -103,7 +103,7 @@ services:
ports:
- "8888:8888"
- "5678:5678"
user: ${UID}:${GID}
user: ${HOST_UID}:anaconda
volumes:
- .:/src
- /tmp/.X11-unix:/tmp/.X11-unix:rw
Expand Down
4 changes: 0 additions & 4 deletions test_requirements.txt

This file was deleted.