Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden attributes #1088

Closed
wants to merge 10 commits into from
Closed

Hidden attributes #1088

wants to merge 10 commits into from

Conversation

A-Baji
Copy link
Collaborator

@A-Baji A-Baji commented Jun 1, 2023

No description provided.

@A-Baji A-Baji linked an issue Jun 1, 2023 that may be closed by this pull request
Comment on lines +294 to +309
(
set(
[
n
for n in self.original_heading.names
if not self.original_heading.attributes[n].is_hidden
]
)
& set(
[
n
for n in other.original_heading.names
if not other.original_heading.attributes[n].is_hidden
]
)
)
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(
set(
[
n
for n in self.original_heading.names
if not self.original_heading.attributes[n].is_hidden
]
)
& set(
[
n
for n in other.original_heading.names
if not other.original_heading.attributes[n].is_hidden
]
)
)
set(
n
for n in self.original_heading.names
if (
not self.original_heading.attributes[n].is_hidden and
not other.original_heading.attributes[n].is_hidden
)
)

Comment on lines +292 to +296
[
name
for name in heading.as_dtype.names
if not heading.attributes[name].is_hidden
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[
name
for name in heading.as_dtype.names
if not heading.attributes[name].is_hidden
],
(
name
for name in heading.as_dtype.names
if not heading.attributes[name].is_hidden
),

Comment on lines +45 to +49
[
"+" + "-" * (widths[column] - 2) + "+"
for column in columns
if not rel.heading.attributes[column].is_hidden
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[
"+" + "-" * (widths[column] - 2) + "+"
for column in columns
if not rel.heading.attributes[column].is_hidden
]
"+" + "-" * (widths[column] - 2) + "+"
for column in columns
if not rel.heading.attributes[column].is_hidden

@A-Baji A-Baji closed this Jun 14, 2023
@A-Baji A-Baji removed a link to an issue Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants