-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 and MySQL 5.7 #1148
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL 8.0 in Docker was ignoring the MYSQL_ROOT_PASSWORD environment variable, setting the default user/pass to root and password. Update the env vars in the dev stack to match these values.
Fix dev container
PLAT-138 Follow Up to datajoint#1114
Clean up modules that were migrated in PRs: datajoint#1136, 1137, 1138, 1139, 1140
No reason for this to be defined in the fixture. Move to the module level to stay consistent.
Ensures that dj.blob.use_32bit_dims is turned off even if test_insert_longblob fails.
A possible fix for datajoint#1145.
PLAT-107: Clean up
PLAT-144: Update developer docs
This was referenced Jan 3, 2024
Open
@dimitri-yatsenko , @corprew , and @ethho agreed that for OS projects, we will not support versions of dependencies that are no longer receiving security updates. This includes MySQL 5.7, so we will deprecate this version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add support for Python 3.10 and 3.11 with MySQL 5.7, fixing #1149 . My question to @dimitri-yatsenko is: do we even want to support this use case?
JIRA ticket: https://datajoint.atlassian.net/browse/PLAT-188
As discovered in #1146 (comment), calls to
dj.conn
anddj.Connection
sometimes fail when called with default arguments, using Python 3.11 and MySQL 5.7. All tests pass with Python <=3.8 and MySQL 5.7 or 8.0, and all tests pass with Python 3.11 and MySQL 8.0, as corroborated by CI in #1146.Additional Details
I believe that these failures relate to the default TLS/SSL configuration in MySQL 5.7 and 8.0, and some assumptions that we make about this default configuration when setting the default values (particularly the
use_tls
kwarg) indatajoint.conn
anddatajoint.Connection.__init__
. This might be due to an incompatibility between MySQL 5.7 and PyMySQL v1.0.2, though I'll note thatpymysql==1.0.2
used in the pytest containers I tried for both Python 3.8 and Python 3.11:Console logs
Commits