New spikeglx and probeinterface #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the discussion, @ttngu207. You have tested this with the meta file, and we will merge once we test these changes with the entire pipeline by triggering spike sorting. |
kabilar
reviewed
Aug 24, 2023
kabilar
reviewed
Aug 24, 2023
added 2 commits
August 24, 2023 19:20
JaerongA
previously approved these changes
Sep 14, 2023
Comment on lines
+117
to
+118
| electrode_layouts = probe_geometry.build_npx_probe( | ||
| **{**probe_params, **probe_type} |
There was a problem hiding this comment.
Suggested change
| electrode_layouts = probe_geometry.build_npx_probe( | |
| **{**probe_params, **probe_type} | |
| electrode_layouts = probe_geometry.build_npx_probe( | |
| **probe_params, **probe_type |
There was a problem hiding this comment.
The suggested change would error out if there are duplicating keys between the two dictionaries.
The original approach is more robust in the sense that it would merge dictionaries.
Co-authored-by: Dimitri Yatsenko <dimitri@datajoint.com>
Co-authored-by: Dimitri Yatsenko <dimitri@datajoint.com>
kabilar
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #168